-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style checks #2376
Add style checks #2376
Conversation
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5865/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
retest this please |
@wpoely86: most of the code supporting the style checks should be added in framework, so we can also use it in |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5866/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5867/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@wpoely86: all PRs that include style checks merged, please sync with |
* develop: (227 commits) consistently use %(perlver)s disable optarch toolchain option to dance around internal compiler error additional style fixes in xtrans easyconfigs additional style fixes in TCC, Vampir, VampirServer and ViennaRNA easyconfigs Don't use %(perl)s and add Perl as a dep. additional style fixes in psmpi easyconfigs additional style fixes in Python easyconfigs additional style fixes in ParMETIS easyconfigs add comments in patch files {vis}[intel/2016a] PyFFmpeg 2.1beta + FFmpeg 0.10.16 additional style fixes in OpenFOAM easyconfigs additional style fixes in Oger easyconfigs additional style fixes in nettle easyconfigs additional style fixes in ncurses easyconfigs additional style fixes in NCO easyconfigs additional style fixes in MultiNest easyconfigs additional style fixes in MCR easyconfigs Use of source name template Messing w/ the %s vs %%(perl)s style interpolation. Use Perl suffix and factor out 'kmer' ...
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6274/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Yes, see #2506 |
@boegel @rjeschmi
Based on pep8. The first test will fail as example. Will push fixes in a moment.